[vlc-devel] commit: Do not destroy vout on aspect ratio change only. (Laurent Aimar )

Marian Ďurkovič md at bts.sk
Thu Sep 11 08:58:33 CEST 2008

On Wed, 10 Sep 2008 22:35:00 +0200, Laurent Aimar wrote
> On Wed, Sep 10, 2008, git version control wrote:
> > vlc | branch: master | Laurent Aimar <fenrir at videolan.org> | Wed Sep 10
22:24:35 2008 +0200| [3065dd7bff1eaad874566db22c07b5538a575904] | committer:
Laurent Aimar 
> > 
> > Do not destroy vout on aspect ratio change only.
> > 
> > The user aspect ratio and resize will still be lost on an AR aspect ratio
> > (we may want to keep at least the requested resie).
>  I would like confirmation that it fixes the AR changes for everyone 
> and report that it does not create regressions before backporting this 
> one to 0.9.

Works fine here (no crashes anymore), however there's one regression - AR change
is ignored when some video filter (e.g. deinterlace) is active. The reason is
that in such case, we're modifying filter variables and not real vout variables...

On the other hand, with AspectCallback it works, since callbacks are forwarded
through video filters to the real vout. I.e. the AspectCallback is first
executed on filter variables, then the second time on real vout variables.
Couldn't we trigger AspectCallback and supply it with new AR - this way we
probably avoid also code duplication...

    With kind regards,


More information about the vlc-devel mailing list