[vlc-devel] commit: HTTP: sanity check ( Rémi Denis-Courmont )

[Rémi Denis-Courmont]

On Wed, 17 Sep 2008 10:15:20 +0300, Ilkka Ollakka
<ilkka.ollakka+vlc at oamk.fi> wrote:
>> @@ -1019,8 +1019,8 @@ static int Connect( access_t *p_access, int64_t
> i_tell )
>>      p_access->info.i_pos  = i_tell;
>>      p_access->info.b_eof  = false;
>>  
>> -
>>      /* Open connection */
>> +    assert( p_sys->fd == -1 );
>>      p_sys->fd = net_ConnectTCP( p_access, srv.psz_host, srv.i_port );
> 
> This assert basicly breaks seeking and authentication in http-access in
> current codebase.

It does not. There are no functional changes; it just enforces a
pre-existing invariant.

If this crashes, then it was already broken (not a big surprise considering
the spaghettiness of the HTTP access).

-- 
Rémi Denis-Courmont