[vlc-devel] commit: HTTP: sanity check ( Rémi Denis-Courmont )

[Ilkka Ollakka]

On ke 17. syyskuuta 2008 10:02:44, Rémi Denis-Courmont wrote:
> 
> On Wed, 17 Sep 2008 10:15:20 +0300, Ilkka Ollakka
> <ilkka.ollakka+vlc at oamk.fi> wrote:
> >> @@ -1019,8 +1019,8 @@ static int Connect( access_t *p_access, int64_t
> > i_tell )
> >>      p_access->info.i_pos  = i_tell;
> >>      p_access->info.b_eof  = false;
> >>  
> >> -
> >>      /* Open connection */
> >> +    assert( p_sys->fd == -1 );
> >>      p_sys->fd = net_ConnectTCP( p_access, srv.psz_host, srv.i_port );
> > 
> > This assert basicly breaks seeking and authentication in http-access in
> > current codebase.
> 
> It does not. There are no functional changes; it just enforces a
> pre-existing invariant.
> 
> If this crashes, then it was already broken (not a big surprise considering
> the spaghettiness of the HTTP access).

Ok, it makes HTTP access-code brokeness to surface more visible then.
But basicly it triggers in simple case where http-server returns 401, or
user tries to play mp4-file from http (seeking calls connect).

-- 
Ilkka Ollakka
Cinemuck, n.:
	The combination of popcorn, soda, and melted chocolate which
covers the floors of movie theaters.
		-- Rich Hall, "Sniglets"
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: not available
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20080917/47f1e53a/attachment.sig>