[vlc-devel] Fwd: E SVN: raster trunk/e/src/bin

[Christophe Massiot]

To whom it may concern, I have found in their ML some criticism from
Raster of the E project about the behaviour of our X11 module :

---------- Forwarded message ----------
From: Enlightenment SVN <no-reply at enlightenment.org>
Date: Fri, Sep 19, 2008 at 11:44 AM
Subject: E SVN: raster trunk/e/src/bin
To: enlightenment-svn at lists.sourceforge.net


Author:       raster
Date:         2008-09-19 02:44:07 -0700 (Fri, 19 Sep 2008)
New Revision: 36093

Log:
 and - that vlc fullscreen bug. found. fixed. but vlc's x11 code is really
 nasty. does some utterly evil things. should i send off some suggestions to
 them? (like 1. dont reparent the window in xcommon.c line 217, dont play with
 wm focus policies in xcommon.c line 2269 - just dont send the
 _NET_ACTIVE_WINDOW, you shouldnt' need to (wm should make the focus be
 correct itself and wm's that don't should get a freindly reminder from users
 when they dont remain consistent with focus policy), and then... xcommon.c
 2317 remove the do {} while loop - i can think of many reasons the wm may
 choose not to map your client window (yet - or ever), so this will never work
 "reliably" always. just put in an XSync(p_vout->p_sys->p_display, False);
 instead to force the x pipe to flush and do everything you asked before
 returning control to the code and thus avoiding any badaccess stuff from x).



[...]

----- End forwarded message -----
-- 
Christophe Massiot.