[vlc-devel] [RFC] Option whitelisting policy

[Rémi Duraffort]

> > +++ b/modules/access/cdda/cdda.c
> >  #ifdef HAVE_LIBCDDB
> > @@ -177,27 +183,32 @@ vlc_module_begin();
> >                  "Track %T. %t - %p %A", NULL,
> >                  N_("Format to use in playlist \"title\" field when using CDDB"),
> >                  CDDB_TITLE_FMT_LONGTEXT, true );
> > +        change_safe();
> It should be safe, BUT I am not sure the implementation is.
IMHO the implementation (on vlc source code) seams safe.

 
> >      add_integer( "http-caching", 4 * DEFAULT_PTS_DELAY / 1000, NULL,
> >                   CACHING_TEXT, CACHING_LONGTEXT, true );
> > +        change_safe();
> >      add_string( "http-user-agent", COPYRIGHT_MESSAGE , NULL, AGENT_TEXT,
> >                  AGENT_LONGTEXT, true );
> > +        change_safe();
> I don't really like it but maybe...
Nor do I (just to avoid having funny (or not) user-agent send by vlc
because a website changed it).

-- 
ivoire | Rémi Duraffort