[vlc-devel] Gsoc 2008 timeshift patch 1

[Rémi Denis-Courmont]

Le jeudi 25 septembre 2008 19:01:18 Dylan Yudaken, vous avez écrit :
> attached with fixes.

Do not replace _correct_ unsigned (or size_t, or even ssize_t for that matter) 
with dubious int.

I also don't get the point of the delete-on-quit option... Why would someone 
want to not delete the files?

Finally, the C run-time normally takes care of deleting temporary files, which 
is more reliable (if VLC crashes) and safer (not deleting someone else file) 
than doing it by hand.

-- 
Rémi Denis-Courmont
http://git.remlab.net/cgi-bin/gitweb.cgi?p=vlc-courmisch.git;a=summary