[vlc-devel] Gsoc 2008 timeshift patch 1

[Dylan Yudaken]

Rémi Denis-Courmont wrote:
> Le jeudi 25 septembre 2008 19:01:18 Dylan Yudaken, vous avez écrit :
>   
>> attached with fixes.
>>     
>
> Do not replace _correct_ unsigned (or size_t, or even ssize_t for that matter) 
> with dubious int.
>
>   
changed, sorry I missed that
> I also don't get the point of the delete-on-quit option... Why would someone 
> want to not delete the files?
>   
It is quite useful if, for instance, you are watching TV with vlc and 
want to dump all the data files somewhere after using vlc (to watch 
again). it deletes them anyway on startup again.
> Finally, the C run-time normally takes care of deleting temporary files, which 
> is more reliable (if VLC crashes) and safer (not deleting someone else file) 
> than doing it by hand.
>   
agreed - but then you cant keep files after using vlc.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20080928/047a7cea/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-GSOC-2008-timeshift-module-rewrite.patch
Type: application/mbox
Size: 31238 bytes
Desc: not available
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20080928/047a7cea/attachment.mbox>