[vlc-devel] commit: win32: fix %zu fixups - dont use mingw's vsnprintf (David Flynn )

[xxcv]

Jean-Baptiste Kempf wrote:
> On Sat, Apr 04, 2009 at 08:28:37PM +1100, xxcv wrote :
>   
>> git version control wrote:
>>     
>>> vlc | branch: master | David Flynn <davidf at rd.bbc.co.uk> | Wed Apr  1 
>>> 21:40:02 2009 +0000| [151982aab503fa812cd4d6e830df34e78871c106] | 
>>> committer: Jean-Baptiste Kempf 
>>> win32: fix %zu fixups - dont use mingw's vsnprintf
>>>
>>> Traditionally, MSVCRT has provided vsnprintf as _vsnprintf;
>>> to 'aid' portability/standards compliance, mingw provide a
>>> static version of [v]snprintf that is buggy.
>>>
>>> The bug manifests as %lx is treated as a 64bit argument not
>>> 32bit, ie consumes two 32bit parameters.  if a %s were to
>>> follow a %lx, bad things can happen.
>>>
>>> Solution: Be sure to use the MSVCRT version, at least it
>>> behaves as expected
>>>
>>> Additionally, make it a bit more obvious when vlc wrappers
>>> are being called by other wrappers.
>>>
>>> Signed-off-by: David Flynn <davidf at rd.bbc.co.uk>
>>> Signed-off-by: Jean-Baptiste Kempf <jb at videolan.org>
>>>  
>>>       
>> Did anybody else tested these patches before you signed them off and commit?
>>     
>
> I tested them and linkfanel did on WinCE.
>
>   
>> Because I just found out it crashes when loading wmv / asf files... #2629
>>     
>
> Are you sure you are not hitting the WMA/SSE bug from avcodec because my
> latest contrib picked a wrong version of avcodec?
> To be sure, try to deactivate SSE/SSE2 in VLC prefs and restart it.
>
> Best random Regards,
>
>   
I am going to revert these 4 patches from David ..and retest.
Pretty sure these patches caused the problem.. because the binary that I 
compiled
from yesterday works fine with wmv since fenrir fixed dmo wrappers. And
there wasn't too many commits or important commits which would affect 
wmv playback
and the most suspicious commits are these four.

Regards.


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20090404/31d7a3b9/attachment.html>