[vlc-devel] [PATCH 17/20] ADD for module configs: list of slave config options

Rémi Denis-Courmont rem at videolan.org
Tue Apr 21 09:37:56 CEST 2009


Le mardi 21 avril 2009, basos g a écrit :
> I understand that this would be more convenient when declaring
> masters. And i could provide a modified implementation for the plugin
> interface (e.g. provide a master with the apropriate call to a macro
> at the declaration of the slave plugin, rather a list of slaves at
> the declaration of a master plugin). But the underlying structure
> would still be a list of slaves stored at the master configuration.
> This is needed as it will provide faster execution ( bear in mind
> that slaves seeking could be triggered by UI events and should
> respond fast enough). Also the implementation for this is already
> defined.

A single slaves list per master will become a terrible mess if we ever 
need to ifdef parts of it.

In fact, I really don't like the way you put all the logic in the UI. 
That sort of stuff belongs in the core, hidden. I haven't been cleaning 
the module and configuration for two years for others to come and 
entangle it again 6 months later.

-- 
Rémi Denis-Courmont
http://www.remlab.net/



More information about the vlc-devel mailing list