[vlc-devel] [PATCH 17/20] ADD for module configs: list of slave config options

[basos g]

2009/4/21 Rémi Denis-Courmont <rem at videolan.org>

> Le mardi 21 avril 2009, basos g a écrit :
> > I understand that this would be more convenient when declaring
> > masters. And i could provide a modified implementation for the plugin
> > interface (e.g. provide a master with the apropriate call to a macro
> > at the declaration of the slave plugin, rather a list of slaves at
> > the declaration of a master plugin). But the underlying structure
> > would still be a list of slaves stored at the master configuration.
> > This is needed as it will provide faster execution ( bear in mind
> > that slaves seeking could be triggered by UI events and should
> > respond fast enough). Also the implementation for this is already
> > defined.
>
> A single slaves list per master will become a terrible mess if we ever
> need to ifdef parts of it.


I don't see why this would happen ? It would be a list like the psz_list
member of the configuration item. Why should we need to ifdef something.

>
> In fact, I really don't like the way you put all the logic in the UI.
> That sort of stuff belongs in the core, hidden. I haven't been cleaning
> the module and configuration for two years for others to come and
> entangle it again 6 months later.
>

I am not sure this is wrong. It's a GUI capability : "to fill a GUI list of
options that depend on the value of another configuration item, "

The use case scenario is :
   a user has opened the capture dialog and is presented with a list of
capture devices. He selects one device from the list. This device has some
device dependent capabilities (like the supported resolutions). These
capabilities should be presented to the user with a list of possible values.
Also these lists should be updated when the device selection has been made.

In my implementation the logic for the above scenario is implemented in the
GUI. But to be accomplished it needs support from a configuration item
capability: the psz_slaves_list, that is optional and with no side effects
to the core as it's an informative only list.

So i believe that the logic is correctly split.

 If you have another proposal for the logic tell it.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20090422/704ebcae/attachment.html>