[vlc-devel] [PATCH] HEAAC V1 support via libavcodec

[Rémi Denis-Courmont]

Le mardi 28 avril 2009 11:46:37 Jarmo Torvinen, vous avez écrit :
> HEAAC V1 support via libavcodec
> ----------------------------------
>
> Files:
> 0004-add-HEAAC1-support-via-libavcodec.patch
>
> The patch adds support for (not yet released) patch to libavcodec to
> support HEAAC V1 encoding via 3GPP reference implementation. It is
> not very useful until we have released the 3GPP patch for avcodec.

Traditionnally, we have used AVCODEC version numbers for "new" codecs. 
Following that paradigm, you'll have to resubmit this patch once FFMPEG has 
merged the underlying dependency, and the version number is known. I don't 
know if #ifdef CODEC_ID is acceptable (comments anyone?).

By the way, that would make FFMPEG non-redistributable due to incompatibility 
with the 3GPP copyright license, right? If it includes encoding capability, 
I'm a bit scared that this will trigger the "crippled" FFMPEG warning even 
though it's perfectly normal for this codec to be missing. Expectedly the 
VideoLAN project and the Linux/BSD distros won't be able to include it. This 
might require a small hack at modules/codec/avcodec/encoder.c:244.

-- 
Rémi Denis-Courmont
http://www.remlab.net/