[vlc-devel] [PATCH] HEAAC V1 support via libavcodec

[Måns Rullgård]

Jarmo Torvinen <jarmo.torvinen at jutel.fi> writes:

> HEAAC V1 support via libavcodec
> ----------------------------------
>
> Files:
> 0004-add-HEAAC1-support-via-libavcodec.patch
>
> The patch adds support for (not yet released) patch to libavcodec to 
> support HEAAC V1 encoding via 3GPP reference implementation. It is
> not very useful until we have released the 3GPP patch for avcodec.
>
> Jarmo Torvinen
>
>
> From acda4b447863e2c0a0c83d8835ff59c70d4355ec Mon Sep 17 00:00:00 2001
> From: Jarmo Torvinen <jarmo.torvinen at jutel.fi>
> Date: Mon, 27 Apr 2009 14:01:15 +0300
> Subject: [PATCH] add HEAAC1 support via libavcodec
>
> ---
>  modules/codec/avcodec/fourcc.c |    5 ++++-
>  modules/mux/mpeg/ts.c          |    6 ++++--
>  2 files changed, 8 insertions(+), 3 deletions(-)
>
> diff --git a/modules/codec/avcodec/fourcc.c b/modules/codec/avcodec/fourcc.c
> index 428d8d0..3af2113 100644
> --- a/modules/codec/avcodec/fourcc.c
> +++ b/modules/codec/avcodec/fourcc.c
> @@ -1131,6 +1131,10 @@ static const struct
>        AUDIO_ES, "PCM ULAW" },
>      { VLC_FOURCC('d','a','u','d'), CODEC_ID_PCM_S24DAUD,
>        AUDIO_ES, "PCM ULAW" },
> +#if defined(CODEC_ID_HEAAC)

Firstly, this will not work since CODEC_ID_* are enum values, not
preprocessor macros.  Secondly, whenever HE-AAC support gets added, it
will use CODEC_ID_AAC, not a new one.  Thirdly, FFmpeg-native support
for HE-AAC is being worked on, so there will be no licence issues.

-- 
Måns Rullgård
mans at mansr.com