[vlc-devel] commit: VOUT_WINDOW_SET_FULLSCREEN: control request for fullscreen mode ( Rémi Denis-Courmont )

[Rémi Denis-Courmont]

Le mardi 11 août 2009 21:10:54 Laurent Aimar, vous avez écrit :
> Hi,
>
> On Tue, Aug 11, 2009, git version control wrote:
> > vlc | branch: master | Rémi Denis-Courmont <remi at remlab.net> | Tue Aug 11
> > 20:02:49 2009 +0300| [066325d2f7f8693f171f045e45b50dc70dca988f] |
> > committer: Rémi Denis-Courmont
> >
> > VOUT_WINDOW_SET_FULLSCREEN: control request for fullscreen mode
> >
> > There is a slight ambiguity as to what VOUT_WINDOW_SET_SIZE should do
> > when in full-screen mode though.
>
>  I am not against such approach but IMHO it is way more complicated than
> letting the "vout display" manage it.
>  Because now, you need to implement fullscreen inside at least "qt4" and
> "drawable" and "xcb" vout window providers (so more duplicated code).

Not much code:
 modules/video_output/xcb/window.c |   19 ++++++++++---------
 1 files changed, 10 insertions(+), 9 deletions(-)

> In the case of "drawable" and don't even see how that can be implemented.

Drawable will be factored into xcb_window. We just need to make the create 
window call conditional and a few minor adjustement.

-- 
Rémi Denis-Courmont
http://www.remlab.net/