[vlc-devel] commit: Qt4: store input_item_t* in plitem and handle metadata in model ( Ilkka Ollakka )

[Jakob Leben]

On Thu, Aug 13, 2009 at 2:48 PM, git version control <git at videolan.org>wrote:

> -void PLItem::init( int _i_id, int _i_input_id, bool _is_node, PLItem
> *parent, PLModel *m, QSettings *settings )
> +void PLItem::init( playlist_item_t *_playlist_item, PLItem *parent,
> PLModel *m, QSettings *settings )
>

Also, now you are not only counting on input item pointer to be valid, but
also on playlist item pointer. Are you sure that PLItem functions like this
are always called within PL_LOCK? At least it should be documented that
PL_LOCK must be held upon entering the function!
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20090813/4f134bdd/attachment.html>