[vlc-devel] commit: Qt4: store input_item_t* in plitem and handle metadata in model ( Ilkka Ollakka )

Ilkka Ollakka ilkka.ollakka+vlc at oamk.fi
Thu Aug 13 16:21:04 CEST 2009

On to 13. elokuuta 2009 15.58.08, Jakob Leben wrote:
> On Thu, Aug 13, 2009 at 2:48 PM, git version control <git at videolan.org>wrote:
> > -void PLItem::init( int _i_id, int _i_input_id, bool _is_node, PLItem
> > *parent, PLModel *m, QSettings *settings )
> > +void PLItem::init( playlist_item_t *_playlist_item, PLItem *parent,
> > PLModel *m, QSettings *settings )
> >
> Also, now you are not only counting on input item pointer to be valid, but
> also on playlist item pointer. Are you sure that PLItem functions like this
> are always called within PL_LOCK? At least it should be documented that
> PL_LOCK must be held upon entering the function!

Actually it counted that playlist_item_t pointer was valid in earlier
constructor too, it just passed pointers/parameters littlebit
differently, so no change on that part.

also added that forgotten decref call, seems that I forgot few oneliners
in this changeset.

Ilkka Ollakka
How much does it cost to entice a dope-smoking UNIX system guru to
		-- Brian Boyle, UNIX/WORLD's First Annual Salary Survey
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: not available
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20090813/3e730d63/attachment.sig>

More information about the vlc-devel mailing list