[vlc-devel] EPG on Win32 (#ifdef HAVE_LOCALTIME_R)
remi at remlab.net
Wed Aug 19 09:14:32 CEST 2009
On Wed, 19 Aug 2009 08:44:41 +0200, Marian Ďurkovič <md at bts.sk> wrote:
> On Wed, Aug 19, 2009 at 08:32:37AM +0200, Rémi Denis-Courmont wrote:
>> On Wed, 19 Aug 2009 08:08:38 +0200, Marian Ďurkovič <md at bts.sk> wrote:
>> > #if defined (HAVE_LOCALTIME_R) || defined (WIN32)
>> > What do you think?
>> I think we don't care about hopeless platforms lacking both
>> localtime_r() and a thread-safe localtime().
> Sure, I'm also doing all testing on Linux :-) But unfortunately, the
> here typically have win on their workstations...
And so what? localtime() is thread-safe on Windows. I did say *lack*both*.
> BTW, shouldn't the localtime_r in compat/ actually use memcpy, i.e. look
> like this:
What for? localtime() shall return, and the caller shall provide, a
properly aligned struct tm pointer.
More information about the vlc-devel