[vlc-devel] EPG on Win32 (#ifdef HAVE_LOCALTIME_R)

Marian Ďurkovič md at bts.sk
Wed Aug 19 09:51:31 CEST 2009


On Wed, Aug 19, 2009 at 09:14:32AM +0200, Rémi Denis-Courmont wrote:
> And so what? localtime() is thread-safe on Windows. I did say *lack*both*.

OK, I misunderstand it..

> > BTW, shouldn't the localtime_r in compat/ actually use memcpy, i.e. look
> > like this:
> 
> What for? localtime() shall return, and the caller shall provide, a
> properly aligned struct tm pointer.

Good, if we can rely on that, fine.

So let's just remove the #ifdef HAVE_LOCALTIME_R from src/input/item.c


   Thanks & kind regards,

        M.



More information about the vlc-devel mailing list