[vlc-devel] Can anyone tell me why this patch was done?

[Pierre d'Herbemont]

Hi Niles,

On Aug 19, 2009, at 9:12 PM, Niles Bindel wrote:

> Basically, I'm trying to fix an issue with the playlist not  
> automatically playing the next item in the playlist after completing  
> playback of the currently playing item.  This had been working fine  
> in previous versions of VLC that were in existence prior to the  
> patch I mentioned above.  When I looked into the issue, I found that  
> there was no longer any code in place to accommodate this automatic  
> transitioning ability as there was in the previous versions due to  
> the switch to using a MediaList instead of the Playlist.  I tried to  
> resolve this issue by using the existing MediaListPlayer, however,  
> as I describe in more detail here (http://mailman.videolan.org/pipermail/vlc-devel/2009-August/064366.html 
> ), I ran into a threading deadlock whenever the currently playing  
> item reached its end and tried to move onto the next media list  
> item.  Ultimately, the deadlock is caused by an event callback  
> trying to delete itself.

I am wondering if this kind of feature is relevant in the video  
plugin. Could this be simplified by implementing this kind of feature  
in javascript?

> The simplest test case to replicate this issue would be to create a  
> valid media player, media list, and media list player.  Add two  
> short video files to a media list, set the media list and player for  
> the media list player, start playback and the deadlock will occur as  
> soon as the end of the first file is done playing.

This should have been fixed by now, as test/media_list_player.c passes  
now.

Thanks,

Pierre.

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20090819/8698d0dd/attachment.html>