[vlc-devel] [PATCH] Do not overwrite configuration with command line options

[Rémi Denis-Courmont]

Le vendredi 21 août 2009 05:00:01 Ludovic Fauvet, vous avez écrit :
> Comments are appreciated.

* Please do not add any new identifier with leading underscores. This violates 
the C standard and it is ugly. We have enough of that already.

* I am not convinced we need an "advanced get" API. Maybe I'm wrong, but I 
think the UI should show the "effective" rather than the "real" configuration. 
Otherwise, it would be quite confusing to have some command line parameters 
that don't show up in the Preferences, but still affect the behavior.

* There is no need to export the "advanced put" API. Only the core will ever 
set command line parameters as far as I know.

* You would cause much less code churn by *not* renaming value to 
config_value.

-- 
Rémi Denis-Courmont
http://www.remlab.net/