[vlc-devel] commit: Revert "dts: Initialize i_frame_size to a default value." ( Laurent Aimar )

[Pierre d'Herbemont]

On Aug 24, 2009, at 10:43 PM, git version control wrote:

> vlc | branch: master | Laurent Aimar <fenrir at videolan.org> | Mon Aug  
> 24 22:00:28 2009 +0200| [1853bff167e3797e8f5fd801d18c52adedd3188e] |  
> committer: Laurent Aimar
>
> Revert "dts: Initialize i_frame_size to a default value."
>
> This reverts commit 260dd07fc161a8c20dfdb992c28d7a865eb93c98.
>
> It is useless, the variable cannot be uninitialized, and does not
> generate a warning for me. The patch could prevent finding real
> bug if the code is modified.


Laurent,

I may surely be wrong here, but I am not reading the same code as you  
do.

i_frame_size is only set in the if()s, so this may not happen. And I  
don't see how it wouldn't be triggered. If it is not supposed to happen.

Please either make the code more explicit or add some assert where the  
condition should not happen.

Pierre.