[vlc-devel] commit: Revert "dts: Initialize i_frame_size to a default value." ( Laurent Aimar )

Laurent Aimar fenrir at via.ecp.fr
Mon Aug 24 23:40:26 CEST 2009

On Mon, Aug 24, 2009, Pierre d'Herbemont wrote:
> On Aug 24, 2009, at 10:43 PM, git version control wrote:
>> vlc | branch: master | Laurent Aimar <fenrir at videolan.org> | Mon Aug  
>> 24 22:00:28 2009 +0200| [1853bff167e3797e8f5fd801d18c52adedd3188e] |  
>> committer: Laurent Aimar
>> Revert "dts: Initialize i_frame_size to a default value."
>> This reverts commit 260dd07fc161a8c20dfdb992c28d7a865eb93c98.
>> It is useless, the variable cannot be uninitialized, and does not
>> generate a warning for me. The patch could prevent finding real
>> bug if the code is modified.
> i_frame_size is only set in the if()s, so this may not happen. And I  
> don't see how it wouldn't be triggered. If it is not supposed to happen.
 Ok, it might be not obvious, but SyncInfo can only be triggered if SyncCode
has previouly succeed on the same data, which ensure that i_frame_size is
 I will make it more explicit.


More information about the vlc-devel mailing list