[vlc-devel] commit: Workaround warning on function returned value casted. ( Laurent Aimar )

[Pierre d'Herbemont]

On Aug 25, 2009, at 8:36 AM, Rémi Denis-Courmont wrote:

>
> On Tue, 25 Aug 2009 00:00:26 +0200, Pierre d'Herbemont
> <pdherbemont at gmail.com> wrote:
>>> Yes, but I really hate when one part of the if use {} and the other
>>> one don't.
>>
>> Hum. I would remove it as it is taking more space than needed. No  
>> need
>> to fill with no op char.
>>
>> Whatever, no one seems to agree on the coding style.
>>
>> I would like a precise coding style such as WebKit's one, so that we
>> don't have to argue on taste.
>> http://webkit.org/coding/coding-style.html
>
> And then what? Run the whole code through indent, which will:
> - screw up in a few corner cases,
> - prevent back-porting fixes.

- just accept patch that match coding style.
- apply coding style just to new file.
- Explicitly state the multiple coding styles used in VLC, and enforce  
them, either in new patch, or everywhere.

To said, it is not something I care about much. I am just stating the  
obvious. There is no rule.

> If I had to to choose, I will choose K&R like ffmpeg does

sure.

> but we have already been there, so it's seems pointless to discuss  
> it anymore.

okay.

Pierre.