[vlc-devel] VLC-1.1.0-git Seg faulting on exit on Win2k

[Michael McEll]

Hello,

VLC 1.1.0 git master has been generating a segmentation fault on exit, and when the "Save" button is pressed in the Preference tab on Windows 2000 This first arose around 10 days ago during a burst of commits.

Problem is located in the MainInterface constructor in '/modules/gui/qt4/main_interface.cpp' 'MainInterface::MainInterface'. A test is made to determine which Windows OS is running:
...
 if( GetVersionEx(&winVer) && winVer.dwMajorVersion > 5 && winVer.dwMajorVersion > 0 ){
...
If Vista or later the pointers himl and p_taskbl will then be assigned a value. If Win2k or WinXp neither of those two variables will be assigned a value resulting in a Seg. fault in ~MainInterface() or changeThumbbarButtons() due to 'if (p_taskbl) p_taskbl->vt-> ...'  

My fix is to set himl and p_taskbl to NULL within an else on the OS test, which avoids the above from occurring.



_________________________________________________________________
Celebrate a decade of Messenger with free winks, emoticons, display pics, and more.
http://clk.atdmt.com/UKM/go/157562755/direct/01/
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20090826/a6a0b62b/attachment.html>