[vlc-devel] commit: SDP: don't disallow RTCP RR (Pierre Ynard )

[Rémi Denis-Courmont]

Le lundi 7 décembre 2009 20:11:14 Rémi Denis-Courmont, vous avez écrit :
> This will cause CORRECT implementations of RTP to wrongly send RTCP-RR,
>  thus wasting bandwidth, and clogging up socket buffers on the server.

At least the clogging up part should be fixed now. But that raises again the 
question whether we care about RTCP-RR. In my understanding, we need to check 
those before we deem an RTP session to have timed out. On the other hand, most 
(all?) clients will refresh the session through the RTSP control channel 
instead. This would be easier for us to deal with, and is more secure (TCP is 
more difficult to spoof than UDP). I think there were some patches for that a 
while ago even. Currently, VLC never times out because the RTCP-RR reception 
never was implemented.

-- 
Rémi Denis-Courmont
http://www.remlab.net/
http://fi.linkedin.com/in/remidenis