[vlc-devel] RE : RE : [PATCH] - msw(directx) fullscreen support (newapi)
brezhoneg1 at yahoo.fr
Sun Dec 27 22:15:25 CET 2009
> Le dimanche 27 décembre 2009, brezhoneg1 a écrit :
> > > > - if( p_vout->p_sys->hparent && !p_vout->b_fullscreen )
> > > > + if( p_vout->p_sys->hparent )
> > >
> > > I don't understand the need here.
> > I think it is needed (actually, the comment above the code explains
> > why). Since fullscreen is no longer this module's
> responsability, we
> > cannot but poll
> > the parent window to see changes in size as we do for a normal
> > window. We are not even sure the vout window provider is managing a
> > single fullscreen screen.
> > Maybe, the fullscreen size may vary over time.
> Does the Win32 API not send an event when the window is resized? That
> would seem odd (not to say plain stupid). The X11 outputs are
> registering for resize events on their parent window.
Yes, X11 seems a lot friendlier in that respect. My understanding is
unlike X11, windows are tightly linked to the thread that created them.
If the vout_display thread were to receive notifications, those should
posted by the vout window provider thread (not the OS)
Anyway, vlc design in that matter is a polling system on Windows.
(even if a WM_WINDOWPOSCHANGED is coded, which only reports changes
pertaining to the vout display subwindows)
More information about the vlc-devel