[vlc-devel] RE : [PATCH] - msw(directx) fullscreen support (new api)

[Laurent Aimar]

Hi,

On Sun, Dec 27, 2009, brezhoneg1 wrote:
> > > index f2bbc97..5485185 100644
> > > --- a/modules/video_output/msw/common_vo.c
> > > +++ b/modules/video_output/msw/common_vo.c
> > > @@ -142,7 +142,7 @@ void CommonManage( vout_thread_t *p_vout )  {
> > >      /* If we do not control our window, we check for geometry
> changes
> > >       * ourselves because the parent might not send us its events.
> */
> > > -    if( p_vout->p_sys->hparent && !p_vout->b_fullscreen )
> > > +    if( p_vout->p_sys->hparent )
> >  I don't understand the need here.
> > 
> 
> I think it is needed (actually, the comment above the code explains
> why).
> Since fullscreen is no longer this module's responsability, we cannot
> but poll
> the parent window to see changes in size as we do for a normal window.
> We are not even sure the vout window provider is managing a single
> fullscreen screen.
> Maybe, the fullscreen size may vary over time.
 If tested, then seems fine.

> btw, does common.c work in fullscreen mode, since the same problem
> exists ?
> I don't see any place where the new size is detected in fullscreen mode.
 ie?

> > +        {
> > > +            Win32ToggleFullscreen( p_vout );
> > > +        }
> >  I think it would be better to modify Win32ToggleFullscreen() 
> > directly as it is called more than once (as alreay done by in 
> > new common.c), no ?
> 
> 
> You're right. I rewrote it with common.c as example.
Seems fine.

Regards,

-- 
fenrir