[vlc-devel] [PATCH] gui/macosx: Added menu item to set playback rate back to normal

[Brian Weaver]

I've been wondering about the redesign that is stated in commit log 966d42293a5613a3ce2b55e5e516533680ff2738:

----
commit 966d42293a5613a3ce2b55e5e516533680ff2738
Author: Felix Paul Kühne <fkuehne at videolan.org>
Date:   Thu May 21 23:50:14 2009 +0200

    macosx: merge the nib fle containing Eric Dudiak's interface rework

Makefile.am
extras/package/macosx/Resources/English.lproj/MainMenu.nib/classes.nib
extras/package/macosx/Resources/English.lproj/MainMenu.nib/designable.nib
extras/package/macosx/Resources/English.lproj/MainMenu.nib/info.nib
extras/package/macosx/Resources/English.lproj/MainMenu.nib/keyedobjects.nib
modules/gui/macosx/embeddedwindow.m
modules/gui/macosx/intf.m
modules/gui/macosx/playlist.m
----

Is the goal of the redesign documented anywhere, for example on the wiki? I'm new to the project and I'm wondering if I'm going to need to go dig through the archives to figure out what changed and more importantly why? I've been using 1.0.3 prior to building from source and I find the changes to the main window a bit abrupt. It appears as if the separate controller window has been docked to the bottom of the play window, but the separate controller still pops up too. It feel as if it was left in a half finished state. However, without knowing the goals of the redesign it's hard for anyone to come along, pick up the pieces, and complete the work.

-- Brian


On Dec 31, 2009, at 10:48 AM, Thijs Alkemade wrote:

>> 
>> Hello Thijs,
>> 
>>> On your forums I read that VLC is looking for some more developers for the Mac OS X interface, so, to see if I could help, I checked out and compiled the source and started digging though it.
>> Great!
>> 
>>> 
>>> Meanwhile, I found an easy ticket I thought I could fix: #1122 [1]. Here [2] is a patch which will add an menu item to the "Playback"-menu to set the playback rate back to 1.0x. The file is rather big, as it requires changes to MainMenu.nib (the nibs are included in the diff, which looks rather ugly. If you want the .nibs separately I can send those too).
>> No problem, the patch applied cleanly as you took as the nib didn't change between patch creation and application.
>> 
>> 
>>> Localizations for the menu item are already in place, I think they come from the Qt-version.
>> Indeed.
>> 
>>> I hope I've made the patch correctly and that it can be committed, and I'm looking forward to contributing more to VLC.
>> 
>> Patch is merged and committed to the 1.1. I'm looking forward to further contributions! While I'm at it, I would like to make you aware of Lunettes, our re-write of VLC for Mac, which will become a replacement for the existing code in the future (later in 2010). More info at <http://github.com/pdherbemont/Glasses>
>> 
>> 
> 
> Yes, I've looked at Lunettes, and it looks promising. I've been wondering
> though, does this mean the new interface that is currently in 1.1-git will not
> be used? It feels rather unfinished, and it doesn't look like many people are
> working on it.
> 
> Thijs
> 
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> http://mailman.videolan.org/listinfo/vlc-devel