[vlc-devel] [PATCH] 4 patches to commit: [PATCH] FIX sub filter dead lock issue -- a recently occured dead lock issue

Laurent Aimar fenrir at via.ecp.fr
Mon Feb 2 22:29:02 CET 2009


Hi,

On Mon, Feb 02, 2009, basos g wrote:
> > [PATCH] FIX sub filter dead lock issue -- a recently occured dead lock issue
> >
> > A dead lock was created when adding an spu filter (like marq)
> > because the same mutex was used for spu->p stuff and sub filter
> > chain (p_spu->p->p_chain). A new mutex was added for to update
> > the filter chain.
 Thanks for your work.

> > Maybe in the future the subfiltercallback code will just update a
> > string and the real filter update would take place in the vout
> > code (just like video filter). Then this mutext should only
> > lock that string and remove it from spu_SortSubPictures.
 I have partially implemented this instead of applying the proposed patch as
it make the code simpler [f0fc0b2353b5234746b8e2e5fd7b764d7915f469].
 Could you confirm it fixes all your issue ?

Regards,

-- 
fenrir



More information about the vlc-devel mailing list