[vlc-devel] [PATCH] 4 patches to commit: [PATCH] FIX sub filter dead lock issue -- a recently occured dead lock issue
noxelia at gmail.com
Tue Feb 3 22:33:48 CET 2009
2009/2/2 Laurent Aimar <fenrir at via.ecp.fr>:
> On Mon, Feb 02, 2009, basos g wrote:
>> > [PATCH] FIX sub filter dead lock issue -- a recently occured dead lock issue
>> > A dead lock was created when adding an spu filter (like marq)
>> > because the same mutex was used for spu->p stuff and sub filter
>> > chain (p_spu->p->p_chain). A new mutex was added for to update
>> > the filter chain.
> Thanks for your work.
>> > Maybe in the future the subfiltercallback code will just update a
>> > string and the real filter update would take place in the vout
>> > code (just like video filter). Then this mutext should only
>> > lock that string and remove it from spu_SortSubPictures.
> I have partially implemented this instead of applying the proposed patch as
> it make the code simpler [f0fc0b2353b5234746b8e2e5fd7b764d7915f469].
> Could you confirm it fixes all your issue ?
yes, the dead lock does not occur after this patch. In addition that's
the thing that should be done for the sub filter chain update.
Effectively this update takes place in the vout_thread, and does not
expose spu internals to video_output.c. So it is a good solution.
More information about the vlc-devel