[vlc-devel] [PATCH] ZIP Module - Use the system minizip when available

Jean-Baptiste Kempf jb at videolan.org
Wed Feb 11 19:32:38 CET 2009


On Wed, Feb 11, 2009 at 06:00:37PM +0200, Rémi Denis-Courmont wrote :
> Le mercredi 11 février 2009 11:46:53 Nicolas Chauvet (kwizart), vous avez 
> écrit :
> > - Ship the vlc module header zip.h
> >  (rename isn't needed once the file in ship)
> > - Detect minizip presence with pkgconfig
> > - if .pc not available, try to assume presence from unzip.h
> > - Move the zlib.h detection in one place (after pkgconfig macro)
> >  minizip in bundled within zlib in some distro
> > - Adds -lz in module that needs it in one place
> > - Prevent the compilation of libs/unzip if minizip is available
> >  (it shound't prevent this directory to be bundled with the sources)
> 
> Again, you sent a broken untested patch.
Fixed in [3f15f9d9c02cf11f45fe18924fcc71809a38be18]

Best Regards,

-- 
Jean-Baptiste Kempf
http://www.jbkempf.com/



More information about the vlc-devel mailing list