[vlc-devel] [PATCH] ZIP Module - Use the system minizip when available

[Rémi Denis-Courmont]

Le mercredi 11 février 2009 20:32:38 Jean-Baptiste Kempf, vous avez écrit :
> On Wed, Feb 11, 2009 at 06:00:37PM +0200, Rémi Denis-Courmont wrote :
> > Le mercredi 11 février 2009 11:46:53 Nicolas Chauvet (kwizart), vous avez
> >
> > écrit :
> > > - Ship the vlc module header zip.h
> > >  (rename isn't needed once the file in ship)
> > > - Detect minizip presence with pkgconfig
> > > - if .pc not available, try to assume presence from unzip.h
> > > - Move the zlib.h detection in one place (after pkgconfig macro)
> > >  minizip in bundled within zlib in some distro
> > > - Adds -lz in module that needs it in one place
> > > - Prevent the compilation of libs/unzip if minizip is available
> > >  (it shound't prevent this directory to be bundled with the sources)
> >
> > Again, you sent a broken untested patch.
>
> Fixed in [3f15f9d9c02cf11f45fe18924fcc71809a38be18]

If there is no push back against crappy patches, there is no incentive for 
people to test and fix their crap before they submit it. This is not fair to 
those who do test, and creates an incentive to not test properly. And the 
more crap, the less reviewers, the more crap, the less reviewers, etc.

Besides, it is highly objectionable from an educational perspective. This 
patch was in no way time-critical, that it would have needed to be fixed.

-- 
Rémi Denis-Courmont
http://git.remlab.net/cgi-bin/gitweb.cgi?p=vlc-courmisch.git;a=summary