[vlc-devel] commit: macosx: added missing playlist locks ( Felix Paul Kühne )

[Rémi Denis-Courmont]

Le jeudi 19 février 2009 16:37:34 git version control, vous avez écrit :
> vlc | branch: master | Felix Paul Kühne <fkuehne at videolan.org> | Wed Feb 18
> 10:55:32 2009 +0100| [0bd6fe5f997142bfaa6f24244d966fd9d040faf2] |
> committer: Felix Paul Kühne
>
> macosx: added missing playlist locks
>
> > http://git.videolan.org/gitweb.cgi/vlc.git/?a=commit;h=0bd6fe5f997142bfaa
> >6f24244d966fd9d040faf2
>
> ---
>
>  modules/gui/macosx/intf.m     |    6 ++++++
>  modules/gui/macosx/playlist.m |    4 ++++
>  2 files changed, 10 insertions(+), 0 deletions(-)
>
> diff --git a/modules/gui/macosx/intf.m b/modules/gui/macosx/intf.m
> index 2ac52a1..9b64436 100644
> --- a/modules/gui/macosx/intf.m
> +++ b/modules/gui/macosx/intf.m
> @@ -1544,7 +1544,11 @@ static void * manage_cleanup( void * args )
>              /* update our info-panel to reflect the new item, if we don't
> show * the playlist or the selection is empty */
>              if( [self isPlaylistCollapsed] == YES )
> +            {
> +                PL_LOCK;
>                  [[self getInfo] updatePanelWithItem:
> playlist_CurrentPlayingItem( p_playlist )->p_input]; +               
> PL_UNLOCK;
> +            }

I don't know the playlist code very well - but... it seems odd that one would 
want to get the input item, do nothing with it and then unlock.

-- 
Rémi Denis-Courmont
http://git.remlab.net/cgi-bin/gitweb.cgi?p=vlc-courmisch.git;a=summary