[vlc-devel] RE : [PATCH] -- corrects two skins2 crashes

brezhoneg1 brezhoneg1 at yahoo.fr
Fri Feb 20 14:01:56 CET 2009

> On Thu, Feb 19, 2009 at 12:33:27AM +0100, brezhoneg1 wrote :
> > This patch corrects segfaults when the video widget of a skin
> > exist or is hidden.
> Sorry, I cannot test, the skins are very broken here, and don't even
> show a video.

Are they really that broken?  

I've tested them with latest git on Linux and the 2009-02-11 build from
your web site on Windows.

Here are the feedbacks:

- On Linux
The only big problem was crashes when no video widget is visible (Null
pointer which means crashing at the vout level) (corrected by the patch)

- On Windows
In the 2009-02-11 build, skin.dtd and skin.catalog were missing. I had
to retrieve them elsewhere and copy them to the default skins directory.
No crashes on Windows (a Null pointer doesn't seem to upset the windows
vout the same way it does with Linux !).

- Design issue
When a skin has got a video window in a hidden state, it could be better
to trigger showing the video window and use it rather than deliver a
null pointer to vout which then spawns a non-skinned window.

To wrap it up,
- one patch (rather straightforward and self-explanatory) to prevent
crashes on Linux
- sbdy has to make sure Windows build does ship skin.dtd and
- In future (paradise?), design issue should be looked at



More information about the vlc-devel mailing list