[vlc-devel] RE : [PATCH] -- corrects two skins2 crashes

[Jean-Baptiste Kempf]

On Fri, Feb 20, 2009 at 02:01:56PM +0100, brezhoneg1 wrote :
> Are they really that broken?  
Here, yes :D

> I've tested them with latest git on Linux and the 2009-02-11 build from
> your web site on Windows.
> Here are the feedbacks:
> 
> - On Linux
> The only big problem was crashes when no video widget is visible (Null
> pointer which means crashing at the vout level) (corrected by the patch)
  And applied.

> - On Windows
> In the 2009-02-11 build, skin.dtd and skin.catalog were missing. I had
> to retrieve them elsewhere and copy them to the default skins directory.

Build system issue, not really important, but still the skin.dtd and
catalog are not moved to $(builddir)/share...

> - Design issue
> When a skin has got a video window in a hidden state, it could be better
> to trigger showing the video window and use it rather than deliver a
> null pointer to vout which then spawns a non-skinned window.
Patch?

> To wrap it up,
> - one patch (rather straightforward and self-explanatory) to prevent
> crashes on Linux
> - sbdy has to make sure Windows build does ship skin.dtd and
> skin.catalog
> - In future (paradise?), design issue should be looked at

To me, there are more issues, especially the skin reparenting of video
outputs (see trac)

Best Regards,

-- 
Jean-Baptiste Kempf
http://www.jbkempf.com/