[vlc-devel] [PATCH] FIX: Dshow "none" device open (#2201). Some cleaning

[J Decker]

>
> Possibly you have right on  this. The interface should not add the
> quotes. But anyway does it hurt to dequote string input options? It is
> a heterogenous infastructure ( parsing is done in various places ) so
> this is a workaround.. And this bug is distributed. Parsing is done in
> qt4 module and parameters are used in dshow. All the parsing code
> should be in one place (for me) .
>
> My long term suggestion would be to parse input options at one place
> (input thread create() ?)  and fill input parameters from there. But
> for now this should do the trick.

This sounds like a very very good idea.  All parsers I write for
command line options remove the quotes and keep it as one null
terminated sequence of characters otherwise.  This is consistant for
input from shells like bash and well written command line programs for
windows.  And, the parsing of the single line of options is absolutely
the correct place for removing the quotes, not at an upper level
plugin.

> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> http://mailman.videolan.org/listinfo/vlc-devel
>