[vlc-devel] [PATCH] FIX: Dshow "none" device open (#2201). Some cleaning
noxelia at gmail.com
Sun Feb 22 17:40:27 CET 2009
2009/2/22 J Decker <d3ck0r at gmail.com>:
>> Possibly you have right on this. The interface should not add the
>> quotes. But anyway does it hurt to dequote string input options? It is
>> a heterogenous infastructure ( parsing is done in various places ) so
>> this is a workaround.. And this bug is distributed. Parsing is done in
>> qt4 module and parameters are used in dshow. All the parsing code
>> should be in one place (for me) .
>> My long term suggestion would be to parse input options at one place
>> (input thread create() ?) and fill input parameters from there. But
>> for now this should do the trick.
> This sounds like a very very good idea. All parsers I write for
> command line options remove the quotes and keep it as one null
> terminated sequence of characters otherwise. This is consistant for
> input from shells like bash and well written command line programs for
> windows. And, the parsing of the single line of options is absolutely
> the correct place for removing the quotes, not at an upper level
I'll investigate this another time...
To sum up
- command line options
- input options
- config options
The 1st is parsed in the argv parser and assigned as inheritable
variables on libvlc
The 2nd is parsed on many places (qt4 iface, don't know from argv, some plugins)
The 3rd is parsed from config_ChainParse inside each module
A question: what are config chain options for ? Shouldn't the other
two be enough (for general and input specific options respectively) ?
After the investigation i'll propose a method to sum up the second
For this special case there are 2 sols
either integrate the patches as is
or integrate only the dshow one and someone else let fix the qt4
parser to remove quotes...
More information about the vlc-devel