[vlc-devel] RE : RE : [PATCH] -- still image demux

[brezhoneg1]

> De : vlc-devel-bounces at videolan.org [mailto:vlc-devel-
> bounces at videolan.org] De la part de Laurent Aimar


>>    vlc image.ext
>  I do not think this one is wanted.
> 
> The fake module will then never terminate. So with a jpeg file inside
> a music directory, you will block on the jpeg :(

Well, it may happen, but it should not be too much of a problem.
If you use dir://, there is an option to ignore certain files (As of
today, jpg is ignored by default anyway).And, you are never really
blocked. Pressing N(ext) will allow you to go on to the next item in the
playlist.

On the plus side  (only possible if fake:// is not explicit),
-  you can easily browse whole image directories :  vlc *.jpg
- create slideshow : vlc --fake-duration  5000 *.jpg
- directly drop images from an explorer into the qt4 playlist


> Btw, with an increased priority, you really need to (at least) check
that
> the
> provided file exist (using stat).
> 

Do you really think it is important ? 
The way it is coded, "vlc image.ext" exactly means "vlc fake://
--fake-file=image.ext"
If the file doesn't exist, there will be identical behaviour (same error
issued at the decoder level).  Testing it earlier just means issuing an
error a bit earlier.


For all other remarks you made, I'm okay with them.

Erwan10