[vlc-devel] RE : RE : [PATCH] -- still image demux
fenrir at via.ecp.fr
Sat Jan 10 10:32:18 CET 2009
On Fri, Jan 09, 2009, brezhoneg1 wrote:
> > De : vlc-devel-bounces at videolan.org [mailto:vlc-devel-
> > bounces at videolan.org] De la part de Laurent Aimar
> >> vlc image.ext
> > I do not think this one is wanted.
> > The fake module will then never terminate. So with a jpeg file inside
> > a music directory, you will block on the jpeg :(
> Well, it may happen, but it should not be too much of a problem.
> If you use dir://, there is an option to ignore certain files (As of
> today, jpg is ignored by default anyway).And, you are never really
> blocked. Pressing N(ext) will allow you to go on to the next item in the
Yes but I do not want vlc hanging indefinitely on image file, it will be
considered as a bug by users.
Now, a solution might be that if fake:// prefix is not used, the duration is
set to a sane value (like a few seconds, 5s at most ?).
> On the plus side (only possible if fake:// is not explicit),
> - you can easily browse whole image directories : vlc *.jpg
> - create slideshow : vlc --fake-duration 5000 *.jpg
> - directly drop images from an explorer into the qt4 playlist
> > Btw, with an increased priority, you really need to (at least) check
> > the
> > provided file exist (using stat).
> Do you really think it is important ?
> The way it is coded, "vlc image.ext" exactly means "vlc fake://
> If the file doesn't exist, there will be identical behaviour (same error
> issued at the decoder level). Testing it earlier just means issuing an
> error a bit earlier.
Yes, but without that check, the fake access_demux will be used and will
hang VLC without displaying anything except an error message that the user
may not even see...
Now, why fake works like this ? I mean why the decoding is delagated to a
decoder ? It prevents using multiple fake in the same input for example, and
make the use of vlc_object_find mandatory :( (That part is not directly related
to your patch).
More information about the vlc-devel