[vlc-devel] dynamicoverlay SetTextColor incorrectly sets color

[Laurent Aimar]

On Tue, Dec 30, 2008, Doug West wrote:
>    The video filter dynamicoverlay function SetTextColor does not appear to
>    set the colors properly. However, if you edit the file
>    dynamicoverlay_commands.c, and change line 272 from:
> 
>    p_params->fontstyle.i_font_color = (r<<24) | (g<<16) | (b<<8);
> 
>    to:
> 
>    p_params->fontstyle.i_font_color = (r<<16) | (g<<8) | b;
> 
>    The colors appear to set properly.
> 
>    I don't know if this is what should be done to correct the problem I saw,
>    or I just didn't understand how to use the SetTextColor function properly.
>    But, since this worked for me and the way I thought SetTextColor should
>    work, I thought I'd pass the information along.

 Thanks for your patch.
It has been applied in [65876ac4ffd3c25d58676b4051374ac5f5379f9c]

Regards,

-- 
fenrir