[vlc-devel] dynamicoverlay SetTextColor incorrectly sets color
noxelia at gmail.com
Thu Jan 15 14:39:20 CET 2009
2009/1/10 Laurent Aimar <fenrir at via.ecp.fr>:
> On Tue, Dec 30, 2008, Doug West wrote:
>> The video filter dynamicoverlay function SetTextColor does not appear to
>> set the colors properly. However, if you edit the file
>> dynamicoverlay_commands.c, and change line 272 from:
>> p_params->fontstyle.i_font_color = (r<<24) | (g<<16) | (b<<8);
>> p_params->fontstyle.i_font_color = (r<<16) | (g<<8) | b;
>> The colors appear to set properly.
>> I don't know if this is what should be done to correct the problem I saw,
>> or I just didn't understand how to use the SetTextColor function properly.
>> But, since this worked for me and the way I thought SetTextColor should
>> work, I thought I'd pass the information along.
> Thanks for your patch.
> It has been applied in [65876ac4ffd3c25d58676b4051374ac5f5379f9c]
There is another change that should be applied fpr this issue as
mentioned in the overseen patch i'd sent.
Reinclude it here ..
-------------- next part --------------
A non-text attachment was scrubbed...
Size: 2071 bytes
Desc: not available
More information about the vlc-devel