[vlc-devel] [PATCH] GSoC: MTP Devices initial release

[Fabio Ritrovato]

Ok, I'v corrected most of the things, I've just some questions...

On Sat, Jan 24, 2009 at 9:05 PM, Rémi Denis-Courmont <rem at videolan.org> wrote:

> +    sscanf( p_access->psz_path, "%"SCNu32":%"SCNu8":%"SCNu16":%d", &i_bus,
> +            &i_dev, &i_product_id, &i_track_id );
>
> I wouldn't hurt to check for formatting errors here.

What do you mean here?

>
> +                    if( asprintf( &psz_to_path, "%s/mtp%d",
> +                        config_GetCacheDir(), i_track_id ) == -1 )
>
> Maybe you should use a normal temporary file, instead of going to .cache ?

What's the difference? And how do i use one?

>
> +        free( p_rawdevices );
> +        msleep( 5000 );
>
> 5 ms is waaaay toooo short. It's not only harmful for power consumption, it's
> so fast it's harmful for scheduling. If you really cannot handle events
> properly, please use something orders longer than that.

Nope, no event handling...
Is 50000 still too short? Any suggestion about how much is good?