[vlc-devel] [PATCH] GSoC: MTP Devices initial release

[Rémi Denis-Courmont]

On Mon, 26 Jan 2009 00:49:53 +0100, Fabio Ritrovato
<exsephiroth87 at gmail.com> wrote:
> Ok, I'v corrected most of the things, I've just some questions...
> 
> On Sat, Jan 24, 2009 at 9:05 PM, Rémi Denis-Courmont <rem at videolan.org>
> wrote:
> 
>> +    sscanf( p_access->psz_path, "%"SCNu32":%"SCNu8":%"SCNu16":%d",
> &i_bus,
>> +            &i_dev, &i_product_id, &i_track_id );
>>
>> I wouldn't hurt to check for formatting errors here.
> 
> What do you mean here?

It wouldn't hurt to check for parsing errors.

>> +                    if( asprintf( &psz_to_path, "%s/mtp%d",
>> +                        config_GetCacheDir(), i_track_id ) == -1 )
>>
>> Maybe you should use a normal temporary file, instead of going to .cache
> ?
> 
> What's the difference? And how do i use one?

It won't clutter .cache with megabytes of MP3 if VLC crashes in the middle.
Also if the distro is not stupid, temporary files get written to memory, so
they don't spin the disk needlessly.
l
-- 
Rémi Denis-Courmont