[vlc-devel] RE : [PATCH] -- scaling activation/deactivation

[brezhoneg1]

> -----Message d'origine-----
> De : vlc-devel-bounces at videolan.org [mailto:vlc-devel-
> bounces at videolan.org] De la part de Jean-Baptiste Kempf
> Envoyé : vendredi 30 janvier 2009 03:00
> À : Mailing list for VLC media player developers
> Objet : Re: [vlc-devel] RE : [PATCH] -- scaling
activation/deactivation
> 
> On Fri, Jan 30, 2009 at 02:11:32AM +0100, brezhoneg1 wrote :
> > Well, it has become difficult to separate things in my working git.
At
> > least, I know this is a consistent set ready to be compiled. But, I
> > agree it is more difficult to sort out different issues.
> 
> Well, isn't there 2 many things in this:
>  - Zoom in vout
>  - Vout recycling
> 
>  in the same patch?


Yes, last email consisted of the two things.

Actually, I am not too happy how I coded things. If you wish, I can
reseparate into two patches.

What I don't like in my work is :
--scaling / --no-scaling :   This misleads people. We always scale
anyway.
--zoom :  I reused this parameter for two different things (very similar
code but functionally different). In windowed mode, zoom sizes the
container (window) and in fullscreen mode, it sizes the inner picture
within the container(screen).


What I propose is :
Create a couple of two options to monitor scaling a picture in a
container (either window or full screen), for example :
--autoscale / --no-autoscale : meaning let or not vlc scale as much as
possible within a container.
--scale-factor : if --no-autoscale is selected, tell vlc which scaling
factor to use (if =1.0, means original size)

--autoscale replaces --scaling
--zoom is for back to its primary goal (sizing a container)
Another set of hotkeys should be assigned to allow resizing the inner
picture within a container (for example, shift-alt-'o' and
ctrl-alt-'o'). It will be used mainly for fullscreen, but can also work
for a window container.


Comments, advices ? 

Erwan10