[vlc-devel] [PATCH] -- fullscreen enhancements
rem at videolan.org
Sat Jan 31 16:45:16 CET 2009
Le vendredi 30 janvier 2009 20:43:13 brezhoneg1, vous avez écrit :
> These patches should be better ....
From a high-level, I'm afraid this is adding even more mess to the sorry
vout_thread_t. That's not your fault - the "vout rework" has been a latent
issue for, hmm... 5 years At least.
I am happy that I am not the release manager who's going to have to decide
whether we can merge this now or not.
- bool b_scale; /**< allow picture scaling
+ bool b_autoscale; /**< auto scaling picture or not
+ uint64_t ll_zoom; /**< scaling factor if no auto */
Very unfortunate ordering w.r.t. padding... And do we really need 64-bits
+void vout_InitWindowSize( vout_thread_t *, unsigned *, unsigned * );
Please avoid adding private functions (no VLC_EXPORT) to public headers. We
have private headers within src/ nowadays.
More information about the vlc-devel