[vlc-devel] RE : [PATCH] -- fullscreen enhancements

brezhoneg1 brezhoneg1 at yahoo.fr
Sat Jan 31 22:38:28 CET 2009

> -----Message d'origine-----
> De : vlc-devel-bounces at videolan.org [mailto:vlc-devel-
> bounces at videolan.org] De la part de Rémi Denis-Courmont
> Envoyé : samedi 31 janvier 2009 16:45
> À : vlc-devel at videolan.org
> Objet : Re: [vlc-devel] [PATCH] -- fullscreen enhancements
> Le vendredi 30 janvier 2009 20:43:13 brezhoneg1, vous avez écrit :
> > These patches should be better ....
> From a high-level, I'm afraid this is adding even more mess to the
> vout_thread_t. That's not your fault - the "vout rework" has been a
> issue for, hmm... 5 years At least.
> I am happy that I am not the release manager who's going to have to
> whether we can merge this now or not.

If  the release manager needs arguments, I will be most happy to help
..... :)

> Very unfortunate ordering w.r.t. padding... And do we really need
> anyway?

You're right about bool and uint64_t ordering. If these patches are
Okayed, I will send a corrected patch.

For uint64_t, I also don't think we need it.
I tried to remain consistent with existing code (took the zoom function
as an example).

> +void vout_InitWindowSize( vout_thread_t *, unsigned *, unsigned * );
> Please avoid adding private functions (no VLC_EXPORT) to public
> We
> have private headers within src/ nowadays.

Ditto, I tried to keep consistency (I used vout_IntfInit as an example,
this function is in include/vlc_vout.h but doesn't use VLC_EXPORT)
I suppose they should be moved to a local .h in src/video_output


More information about the vlc-devel mailing list