[vlc-devel] libvlc API: Add equalizer to audio.c

Rémi Denis-Courmont remi at remlab.net
Sat Jul 25 19:07:35 CEST 2009


Le lundi 20 juillet 2009 11:34:21 Cyril MATHE, vous avez écrit :
> This patch add equalizer audio filter to audio.c.
> It adds two new functions:
>
> libvlc_audio_set_eqz(libvlc_audio_eqz_config_t, libvlc_audio_eqz_t):
> enable/disable equalizer, set a new band value, set an equalizer preset
>
> libvlc_audio_eqz_t libvlc_audio_get_eqz(libvlc_audio_eqz_config_t): get
> equalizer status (enabled or not), get bands values, get equalizer
> preset settings.

Am I reading this right that you return an aggregate type? with a pointer 
inside? Is it a static character constant from libvlc itself? This is OK 
though not optimal... but...

If we remove exceptions, this prototype cannot return an error code :(

-- 
Rémi Denis-Courmont
http://www.remlab.net/




More information about the vlc-devel mailing list