[vlc-devel] Qt4 gui playlist
jakob.leben at gmail.com
Thu Jul 30 10:08:09 CEST 2009
On Wed, Jul 29, 2009 at 6:03 PM, <jpd at videolan.org> wrote:
> On Wed, Jul 29, 2009 at 11:38:29AM +0200, Jakob Leben wrote:
> > I would like to know your opinion about making the process of moving
> > items atomic, meaning that PL_LOCK and PL_UNLOCK is called only once
> > before and after the process as a whole.
> I'm not familiar with that part of the code, but I'd recommend checking
> the code inside the locks doesn't do things like calling other parts
> that also lock other things, or that run for a really long time. Other
> than that, no objection.
That should not be a problem as I am not using in the new code any other
functions that were not already used before inside the locks.
However, I noticed another weird thing: if the option "Display playlist
tree" in "advanced" settings / Playlist is checked, then playlist_TreeMove()
moves always to index 0, no matter what index you pass it.
Does anybody know what the above mentioned option is supposed to do?
And can somebody who knows better the core code (playlist_TreeMove()
function) please check why the problem is happening? (maybe it's not a
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the vlc-devel