[vlc-devel] [PATCH] Qt4 Playlist fix: when moving items keep their original order...
remi at remlab.net
Thu Jul 30 20:49:29 CEST 2009
Le jeudi 30 juillet 2009 21:34:35 Jakob Leben, vous avez écrit :
> The patch makes the drop operation atomic in the sense that it calls
> PL_LOCK and PL_UNLOCK only once before and after the whole operation, thus
> preventing any other thread from messing with it.
This looks quite good, however:
> + playlist_item_t *p_target = 0;
NULL! Implicit int to pointers is ugly and can trigger type size mismatch if
sizeof(int) != sizeof(intptr_t).
> + int i;
> + for( i = 0 ; i< p_parent->i_children ; i++ )
You could move i into the loop, I guess.
More information about the vlc-devel