[vlc-devel] [PATCH] Qt4 Playlist fix: when moving items keep their original order...

[Jakob Leben]

2009/7/30 Rémi Denis-Courmont <remi at remlab.net>

> (...)
> > +        playlist_item_t *p_target = 0;
>
> NULL! Implicit int to pointers is ugly and can trigger type size mismatch
> if
> sizeof(int) != sizeof(intptr_t).
>
> (...)
> > +                int i;
> > +                for( i = 0 ; i< p_parent->i_children ; i++ )
>
> You could move i into the loop, I guess.
>


I agree with what you proposed. I've been a lot in C++ lately so got used to
0 instead of NULL. As for variable declaration inside "for" statement, I
followed examples that I saw around in the rest of the code.

Would you like me to send corrected patch again or will you do it manually?

Kind regards!
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20090730/173bff81/attachment.html>