[vlc-devel] [PATCH 2/2] Made VLCKit's VLCOpenGLVoutView ignore -reshape requests when quit is in progress, thus avoiding a segfault.

Malte Tancred malte at frontbase.com
Mon Jun 1 09:04:15 CEST 2009

On 30 maj 2009, at 20.42, Rémi Denis-Courmont wrote:
> I don't know OSX code, but accessing b_die directly is generally not  
> safe.

Ok, so is there an alternative way to ask whether the p_vout is  
"shutting down"? A quick search through the VLC source tree reveals a  
mix of direct access to b_die, access through vlc_object_alive(), etc.  
Is there a right way to do this?

Further, as I wrote in the patch description, the patch might just be  
treating symptoms. I don't know why the Cocoa view is still getting - 
reshape messages after the movie has been told to stop (and --  
apparently -- at least one object on the cocoa side has been released  
or the a pointer to it mangled, as objc_msgSend segfaults).

So, what does it mean that p_vout->b_die is set? Does it mean one  
shouldn't try to draw anything anymore, or does it mean something  
else? If the former, then it doesn't hurt aborting the -reshape  
method. It would still be good to know why the -reshape is called in  
this situation, and if it could be avoided altogether.


More information about the vlc-devel mailing list